fix(plugin-oracle): make channel-fatal classification testable to unbreak test target#1740
Merged
datlechin merged 1 commit intoJun 21, 2026
Conversation
Contributor
|
Thank you for your contribution! Before we can merge this PR, you need to sign our Contributor License Agreement. To sign, please comment below with:
I have read the CLA Document and I hereby sign the CLA. xuhengyu seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
main HEAD 的
TableProTests/Plugins/OracleConnectionErrorTests.swift(PR #1723 引入)引用OracleConnectionWrapper.isChannelFatalCode,但OracleConnectionWrapper是 OracleDriverPlugin 的 plugin 内部类型,app/test target 通过@testable import TablePro看不到它,导致整个 TableProTests target 编译失败(exit 65),macOS App Tests 全部无法运行,并阻塞其他 PR 的 CI。修复
把
isChannelFatalCode的纯字符串分类逻辑提到 TableProPluginKit 的 publicOracleChannelFatalCode(TableProPluginKit 已有 PluginDriverError / SSLHandshakeError / AWSAuthError 等 driver 特定 error 类型作为先例)。OracleConnectionWrapper转调,行为不变。测试改为import TableProPluginKit测可见类型。PluginKit 改动为新增一个 public enum,纯 additive,无 ABI bump,无需 version bump。
验证
cannot find 'OracleConnectionWrapper'消除)